wgtmac commented on code in PR #50157:
URL: https://github.com/apache/arrow/pull/50157#discussion_r3401429211
##########
cpp/src/parquet/page_index.cc:
##########
@@ -973,6 +979,9 @@ std::unique_ptr<ColumnIndex> ColumnIndex::Make(const
ColumnDescriptor& descr,
// Guard against UB when moving column_index
throw ParquetException("Invalid ColumnIndex boundary_order");
}
+ if (!CanTrustPageIndexMinMax(descr)) {
+ return nullptr;
Review Comment:
Make sense! I've reverted changes related to `ColumnIndex` to return it as
is. Added `ColumnDescriptor::can_use_stats()` to indicate whether `ColumnOrder`
and `SortOrder` assume the stats is valid. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
