dangotbanned commented on code in PR #50168:
URL: https://github.com/apache/arrow/pull/50168#discussion_r3410331152
##########
ci/scripts/python_wheel_validate_contents.py:
##########
@@ -54,9 +54,10 @@ def validate_wheel(path):
info.filename.split("/")[-1] == filename for info in
wheel_zip.filelist
), f"{filename} is missing from the wheel."
- assert any(
- info.filename == "pyarrow/py.typed" for info in wheel_zip.filelist
- ), "pyarrow/py.typed is missing from the wheel."
+ # TODO(GH-48970): Uncomment when stubfiles are complete
+ # assert any(
+ # info.filename == "pyarrow/py.typed" for info in
wheel_zip.filelist
+ # ), "pyarrow/py.typed is missing from the wheel."
source_root = Path(__file__).resolve().parents[2]
stubs_dir = source_root / "python" / "pyarrow-stubs" / "pyarrow"
Review Comment:
@rok I strongly recommend excluding the entire directory.
This is all that is in there? ๐คจ
https://github.com/apache/arrow/blob/4fce185a1a34dd6b409260c142e6e4e148f43995/python/pyarrow-stubs/pyarrow/__init__.pyi#L24-L29
We've been pinning
[`pyarrow<24`](https://github.com/narwhals-dev/narwhals/blob/8f6b947c8ab0ff3c4f9df6fd02081a8a89293b67/pyproject.toml#L98)
and the errors we see in
(https://github.com/narwhals-dev/narwhals/issues/3560) will still be there for
type checkers that aren't `mypy` ๐
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
