dangotbanned commented on code in PR #50168: URL: https://github.com/apache/arrow/pull/50168#discussion_r3419638073
########## python/CMakeLists.txt: ########## @@ -1041,32 +1041,40 @@ endif() # # Type stubs with docstring injection # +# TODO(GH-49831): Temporarily do not install pyarrow-stubs into wheels. +# The stubs are incomplete, and some type checkers consume .pyi files even +# without the py.typed marker. Re-enable this when the stubs are complete. +if(PYARROW_REQUIRE_STUB_DOCSTRINGS) + message(FATAL_ERROR "PYARROW_REQUIRE_STUB_DOCSTRINGS cannot be used while " + "pyarrow-stubs are omitted from wheels (GH-49831).") +endif() +# # Stubs live in pyarrow-stubs/pyarrow/ during development but are installed # alongside the package so type checkers can find them (PEP 561). Review Comment: Maybe tweak this comment and move it up here (https://github.com/rok/arrow/blob/1c4cec99ed9e1639e0a57a3bb2a9880dec99b31e/python/CMakeLists.txt#L1044-L1046) The first comment says they're not installed but the second says they are 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
