Copilot commented on code in PR #50181:
URL: https://github.com/apache/arrow/pull/50181#discussion_r3415214240
##########
ci/scripts/python_wheel_macos_build.sh:
##########
@@ -39,8 +39,10 @@ export SDKROOT=${SDKROOT:-$(xcrun --sdk macosx
--show-sdk-path)}
if [ $arch = "arm64" ]; then
export CMAKE_OSX_ARCHITECTURES="arm64"
+ : ${ARROW_SIMD_LEVEL:="NEON"}
elif [ $arch = "x86_64" ]; then
export CMAKE_OSX_ARCHITECTURES="x86_64"
+ : ${ARROW_SIMD_LEVEL:="SSE4_2"}
Review Comment:
The architecture check and default assignment are currently unquoted (e.g.,
`[ $arch = "arm64" ]` and `: ${ARROW_SIMD_LEVEL:=...}`), which can break under
`set -e` if `arch` is empty and can introduce word-splitting/globbing if
variables ever contain unexpected characters. Since this is a bash script,
using `[[ ... ]]` and quoting the parameter expansion is more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
