Dandandan commented on a change in pull request #320:
URL: https://github.com/apache/arrow-datafusion/pull/320#discussion_r630738770
##########
File path: datafusion/src/physical_plan/planner.rs
##########
@@ -184,19 +184,54 @@ impl DefaultPhysicalPlanner {
let final_group: Vec<Arc<dyn PhysicalExpr>> =
(0..groups.len()).map(|i| col(&groups[i].1)).collect();
- // construct a second aggregation, keeping the final column
name equal to the first aggregation
- // and the expressions corresponding to the respective
aggregate
- Ok(Arc::new(HashAggregateExec::try_new(
- AggregateMode::Final,
- final_group
- .iter()
- .enumerate()
- .map(|(i, expr)| (expr.clone(), groups[i].1.clone()))
- .collect(),
- aggregates,
- initial_aggr,
- input_schema,
- )?))
+ // TODO: dictionary type not yet supported in Hash Repartition
+ let contains_dict = groups
Review comment:
Will create an issue for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
