Dandandan commented on a change in pull request #320:
URL: https://github.com/apache/arrow-datafusion/pull/320#discussion_r630935538
##########
File path: datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -201,7 +203,9 @@ impl ExecutionPlan for HashAggregateExec {
fn required_child_distribution(&self) -> Distribution {
match &self.mode {
- AggregateMode::Partial => Distribution::UnspecifiedDistribution,
+ AggregateMode::Partial | AggregateMode::FinalPartitioned => {
+ Distribution::UnspecifiedDistribution
Review comment:
That's interesting - we could I think add a
`Distribution::HashPartitioned(Vec<Expr>)` variant, which also could be used
later for optimizations.
Currently only `SinglePartition` partition is used for the `MergeExec` rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
