hadrian-reppas opened a new pull request, #50269:
URL: https://github.com/apache/arrow/pull/50269

   ### Rationale for this change
   
   I was looking into #49889 and updated the handling of logical nulls in the 
`is_valid`, `is_null`, and `true_unless_null` kernels. It turns out there is 
some prior work here that I didn't see before I starting implementing my fix 
(#35058, #35036, #37642). For some reason, that work has stalled.
   
   ### What changes are included in this PR?
   
   This PR updates the `IsValidExec`, `IsNullExec`, and `TrueUnlessNullExec` 
kernels so that they call out to a new function `SetLogicalNullBits`. The 
`SetLogicalNullBits` function matches the logic in 
`ArraySpan::ComputeLogicalNullCount()`. The logic is similar enough that they 
may be some opportunities for code deduplication in `dict_util.cc` and 
`ree_util.cc`.
   
   ### Are these changes tested?
   
   Yes
   
   ### Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to