raulcd commented on code in PR #49658:
URL: https://github.com/apache/arrow/pull/49658#discussion_r3497857345
##########
python/pyarrow/src/arrow/python/python_to_arrow.cc:
##########
@@ -826,7 +827,7 @@ class PyDictionaryConverter<U, enable_if_has_string_view<U>>
} else {
ARROW_RETURN_NOT_OK(
PyValue::Convert(this->value_type_, this->options_, value, view_));
- return this->value_builder_->Append(view_.bytes,
static_cast<int32_t>(view_.size));
+ return this->value_builder_->Append(std::string_view(view_.bytes,
view_.size));
Review Comment:
why is this necessary?
##########
cpp/src/arrow/util/converter.h:
##########
@@ -238,7 +238,9 @@ struct MakeConverterImpl {
DICTIONARY_CASE(FloatType);
DICTIONARY_CASE(DoubleType);
DICTIONARY_CASE(BinaryType);
+ DICTIONARY_CASE(LargeBinaryType);
Review Comment:
I am slightly confused because this seems to have already been added into
main, see:
https://github.com/apache/arrow/blob/198423ed43d4c04dc82db1c1aa52a587944fdfdc/cpp/src/arrow/util/converter.h#L229-L244
It was added on this commit three weeks ago:
https://github.com/apache/arrow/commit/b3ba226ef7cf43ba697aa21b671b93ede424d778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
