Benjamin-Philip commented on code in PR #68:
URL: https://github.com/apache/arrow-erlang/pull/68#discussion_r3498266826
##########
.github/workflows/docs.yml:
##########
@@ -83,8 +70,70 @@ jobs:
- name: Upload artifact
uses: actions/upload-pages-artifact@v5
with:
+ name: docs-${{ github.sha }}
path: 'doc'
- - name: Deploy to GitHub Pages
- id: deployment
+ gh_pages:
+ # Only deploy on a push to main
+ if: github.ref_name == 'main' && github.event_name == 'push'
+ name: Deploy to GitHub Pages
+ needs: build
+
+ # Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
+ permissions:
+ contents: read
+ pages: write
+ id-token: write
+
+ environment:
+ name: github-pages
+ url: ${{ steps.deployment.outputs.page_url }}
+
+ # Allow only one concurrent deployment
+ concurrency:
+ group: "pages"
+ cancel-in-progress: true
+
+ runs-on: ubuntu-latest
+ steps:
+ - id: deployment
uses: actions/deploy-pages@v5
+ with:
+ artifact_name: docs-${{ github.sha }}
+
+
+ asf_site:
+ # Only deploy on a push to main
+ if: github.ref_name == 'main' && github.event_name == 'push'
Review Comment:
If we want to correctly handle released versions, maybe we should delay this
PR till the release scripts have been finalized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
