kou commented on code in PR #68:
URL: https://github.com/apache/arrow-erlang/pull/68#discussion_r3502644721
##########
.github/workflows/docs.yml:
##########
@@ -83,8 +70,70 @@ jobs:
- name: Upload artifact
uses: actions/upload-pages-artifact@v5
with:
+ name: docs-${{ github.sha }}
path: 'doc'
- - name: Deploy to GitHub Pages
- id: deployment
+ gh_pages:
+ # Only deploy on a push to main
+ if: github.ref_name == 'main' && github.event_name == 'push'
Review Comment:
> You'd have to disable GitHub Pages from the settings.
OK. It seems that we can't disable GitHub Pages by `.asf.yaml`:
https://github.com/apache/infrastructure-asfyaml/blob/b898fe3bfcedd58c8e8bb1ae47526339bafd1b40/asfyaml/feature/github/pages.py#L93
Could you open an issue for it at
https://github.com/apache/infrastructure-asfyaml/issues ?
> I think GitHub Pages could be used to serve docs from main, while we use
asf-site for releases? Also it's always useful to have multiple mirrors in case
one fails.
Is it really useful...? Both of them have different contents (GitHub Pages
provides docs for main ans arrow.apache.org/erlang provides docs for released
versions). I feel that it's just inconvenient...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
