fallintoplace opened a new pull request, #877:
URL: https://github.com/apache/arrow-go/pull/877

   ### What changed
   
   NewDenseUnionFromArraysWithFieldCodes now rejects type ID and offset arrays 
whose ArrayData offsets differ.
   
   ### Why
   
   Dense unions store the type ID data offset as the union data offset, and 
ValueOffset uses that same offset to index the borrowed offsets buffer. If the 
offsets array is sliced differently from the type IDs array, the dense union 
can read the wrong physical offset entries.
   
   ### Validation
   
   - go test ./arrow/array -run 'TestUnions/TestMakeDenseUnions' -count=1
   - go test ./arrow/array -count=1
   - PARQUET_TEST_DATA=/Users/hoangvu/Code/OSS/arrow-go/parquet-testing/data 
ARROW_TEST_DATA=/Users/hoangvu/Code/OSS/arrow-go/arrow-testing/data go test 
./... -count=1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to