kou commented on PR #49787: URL: https://github.com/apache/arrow/pull/49787#issuecomment-4850822980
I'm suggesting 1. or 2. BTW, https://manpages.ubuntu.com/manpages/focal/man5/odbcinst.ini.5.html says that we should use `odbcinst -i -d -f template.ini` instead of editing `odbc.ini` manually. It seems that our install script https://github.com/apache/arrow/blob/main/cpp/src/arrow/flight/sql/odbc/install/unix/install_odbc.sh edit `/etc/odbcinst.ini` directly. We can use `%post` hook in `.spec` to run `odbcinst`. We can create `odbcinst.ini.template` by CMake's https://cmake.org/cmake/help/latest/command/configure_file.html . We don't need to create it dynamically by a shell script like https://github.com/apache/arrow/blob/main/cpp/src/arrow/flight/sql/odbc/install/unix/install_odbc_ini.sh . > I think it would be beneficial to include the ODBC Linux driver registration script. My initial thinking was that community could use CPack approach first, and then CPack approach can be phased out by `linux-packages` once that is complete. Alternatively, after this PR and #49857 are merged, someone with knowledge in `linux-packages` could merge the 2 approaches together so that `linux-packages` implementation also does ODBC driver registration. We will not make the CPack based packages "offical" packages because it conflicts with existing deb/RPM packages. We should not provide non "official" packages to users. We can provide non "official" packages to only Apache Arrow developers. See also: https://www.apache.org/legal/release-policy.html#publication I think that it's not useful for you. So I suggest the `dev/tasks/linux-packages` approach. > Our team currently doesn't have capacity to test and verify the implementation with `linux-packages`. We appreciate your help here. If you can't test, I can't help you because I don't know the expected behavior... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
