Copilot commented on code in PR #50317:
URL: https://github.com/apache/arrow/pull/50317#discussion_r3506367463
##########
r/inst/build_arrow_static.sh:
##########
@@ -114,7 +114,7 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-G "${CMAKE_GENERATOR:-Unix Makefiles}" \
${SOURCE_DIR}
-${CMAKE} --build . --target install -- -j $N_JOBS
+(unset MAKEFLAGS MFLAGS; ${CMAKE} --build . --target install -- -j "${N_JOBS}")
Review Comment:
Consider using CMake’s generator-agnostic parallel build flag (`--parallel`)
instead of passing `-j` through to the underlying build tool. Since Arrow
requires CMake >= 3.25, `--parallel` is available and avoids relying on
build-tool-specific arguments after `--`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
