kou commented on code in PR #50317:
URL: https://github.com/apache/arrow/pull/50317#discussion_r3510026808


##########
r/inst/build_arrow_static.sh:
##########
@@ -114,7 +114,7 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
     -G "${CMAKE_GENERATOR:-Unix Makefiles}" \
     ${SOURCE_DIR}
 
-${CMAKE} --build . --target install -- -j $N_JOBS
+(unset MAKEFLAGS MFLAGS; ${CMAKE} --build . --target install --parallel 
"${N_JOBS}")

Review Comment:
   It seems that this
   
   ```diff
   diff --git a/r/inst/build_arrow_static.sh b/r/inst/build_arrow_static.sh
   index 349531b75f..02bc4a24c7 100755
   --- a/r/inst/build_arrow_static.sh
   +++ b/r/inst/build_arrow_static.sh
   @@ -114,7 +114,7 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
        -G "${CMAKE_GENERATOR:-Unix Makefiles}" \
        ${SOURCE_DIR}
    
   -${CMAKE} --build . --target install -- -j $N_JOBS
   +${CMAKE} --build . --target install -- -j$N_JOBS
    
    if command -v sccache &> /dev/null; then
      echo "=== sccache stats after the build ==="
   ```
   
   or
   
   ```diff
   diff --git a/r/inst/build_arrow_static.sh b/r/inst/build_arrow_static.sh
   index 349531b75f..0df5240888 100755
   --- a/r/inst/build_arrow_static.sh
   +++ b/r/inst/build_arrow_static.sh
   @@ -114,7 +114,7 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
        -G "${CMAKE_GENERATOR:-Unix Makefiles}" \
        ${SOURCE_DIR}
    
   -${CMAKE} --build . --target install -- -j $N_JOBS
   +${CMAKE} --build . --target install --parallel $N_JOBS
    
    if command -v sccache &> /dev/null; then
      echo "=== sccache stats after the build ==="
   ```
   
   is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to