joechenrh commented on code in PR #880:
URL: https://github.com/apache/arrow-go/pull/880#discussion_r3519035207
##########
parquet/file/row_group_reader.go:
##########
@@ -129,6 +130,13 @@ func (r *RowGroupReader) GetColumnPageReader(i int)
(PageReader, error) {
maxPageHeaderSize: defaultMaxPageHeaderSize,
nrows: col.NumValues(),
mem: r.props.Allocator(),
+ // Streaming (EnablePageStreaming) inputs; only the
unencrypted path is
+ // ever streaming-eligible, so columnCanStream is left
false elsewhere.
+ columnCanStream: r.props.EnablePageStreaming &&
Review Comment:
Add document for both `EnablePageStreaming` and `Data()` to clarify the
change. My judgment is as follows. I wonder if you have any opinions:
I find that `pqarrow` also uses `GetColumnPageReader`, so I prefer
explicitly document this semantic change. Besides, since this new option is off
by default, existing downstream user codes shouldn't be affected when bumping
the package. When a user (or an AI agent) wants to enable the option, they can
find this changes from the comments from `EnablePageStreaming`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
