joechenrh commented on code in PR #880:
URL: https://github.com/apache/arrow-go/pull/880#discussion_r3556550812
##########
parquet/file/row_group_reader.go:
##########
@@ -186,3 +195,21 @@ func (r *RowGroupReader) GetColumnPageReader(i int)
(PageReader, error) {
}
return pr, pr.init(col.Compression(), &ctx)
}
+
+func streamablePhysicalType(t parquet.Type) bool {
+ switch t {
+ case parquet.Types.ByteArray, parquet.Types.FixedLenByteArray:
+ return true
+ default:
+ return false
+ }
+}
+
+func streamableCodec(c compress.Compression) bool {
+ switch c {
+ case compress.Codecs.Uncompressed, compress.Codecs.Gzip,
compress.Codecs.Brotli, compress.Codecs.Zstd:
Review Comment:
Good point, updated in
https://github.com/apache/arrow-go/pull/880/changes/413feca0da42d74c5889f4a4aaa7b1c1e25052aa
with a one-line comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
