fornwall opened a new pull request, #10299:
URL: https://github.com/apache/arrow-rs/pull/10299

   **Disclaimer**: The PR description and the code change was generated by 
claude code. I have reviewed it and think it makes sense, and is ready to dig 
into any eventual issues or make necessary modifications.
   
   The `errno` constants in `ffi_stream.rs` were hardcoded to a single set of 
values, but `ENOSYS` is `78` only on macOS/iOS and the BSDs — on Linux it is 
`38`, on Windows `40`, on Solaris/illumos `89`. On WASI even the other codes 
differ (`EINVAL` is `28`, `EIO` `29`, `ENOMEM` `48`), since WASI numbers its 
errnos independently. A stream exported on Linux therefore reported 
`ArrowError::NotYetImplemented` as `78`, which Linux errno tables read as an 
unrelated code, confusing C consumers that interpret the returned errno.
   
   Take the constants from libc instead, as an optional dependency of the ffi 
feature. It is target-gated off `wasm32-unknown-unknown` — the one target 
without a libc — where no OS interprets the codes anyway, so hardcoded Linux 
values remain.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to