fornwall commented on code in PR #10299:
URL: https://github.com/apache/arrow-rs/pull/10299#discussion_r3578696175
##########
arrow-array/Cargo.toml:
##########
@@ -45,6 +45,11 @@ ahash = { version = "0.8", default-features = false,
features = ["compile-time-r
[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
ahash = { version = "0.8", default-features = false, features =
["runtime-rng"] }
+# Used by the ffi feature for platform-correct errno values. Excluded on
+# wasm32-unknown-unknown, which has no libc.
+[target.'cfg(not(all(target_family = "wasm", target_os =
"unknown")))'.dependencies]
Review Comment:
Just wasm32 would also gate libc off on `wasm32-wasip{1,2}` and
`wasm32-unknown-emscripten`, which do have a libc - and [WASI renumbers its
errnos](https://github.com/WebAssembly/wasi-libc/blob/main/libc-bottom-half/headers/public/__errno_values.h),
so it's relevant to use correct constants there.
The situation for `ahash` is not the same - there `runtime-rng` should be
avoided on all wasm targes, including `wasm32-wasip{1,2}` and
`wasm32-unknown-emscripten`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
