Copilot commented on code in PR #50374:
URL: https://github.com/apache/arrow/pull/50374#discussion_r3542605035
##########
r/tests/testthat/test-Array.R:
##########
@@ -521,23 +521,25 @@ test_that("Array<int8>$as_vector() converts to integer
(ARROW-3794)", {
expect_as_vector(a, u8)
})
-test_that("Arrays of {,u}int{32,64} convert to integer if they can fit", {
+test_that("Arrays of {,u}int{32} convert to integer if they can fit", {
Review Comment:
The test description no longer matches what the test covers: it still
asserts `int64` downcasting behavior but the name now only mentions
`{,u}int{32}`. This can make future failures harder to interpret.
##########
r/man/acero.Rd:
##########
@@ -72,7 +72,7 @@ can assume that the function works in Acero just as it does
in R.
Functions can be called either as \code{pkg::fun()} or just \code{fun()}, i.e.
both
\code{str_sub()} and \code{stringr::str_sub()} work.
-In addition to these functions, you can call any of Arrow's 281 compute
+In addition to these functions, you can call any of Arrow's 253 compute
functions directly. Arrow has many functions that don't map to an existing R
Review Comment:
Hard-coding the number of available compute functions in the docs is brittle
and already inconsistent with other package documentation (e.g.,
`r/R/dplyr-funcs-doc.R` still states 281). Since the count can change with
Arrow versions/build options, prefer wording that avoids a specific number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
