Copilot commented on code in PR #50374: URL: https://github.com/apache/arrow/pull/50374#discussion_r3551251624
########## r/vignettes/data_types.Rmd: ########## @@ -97,12 +97,15 @@ If the value in R does not fall within the permissible range for the correspondi chunked_array(c(10L, 3L, 200L), type = int8()) ``` -When translating from Arrow to R, integer types alway translate to R integers unless one of the following exceptions applies: +When translating from Arrow to R, integer types always translate to R integers unless one of the following exceptions applies: -- If the value of an Arrow uint32 or uint64 falls outside the range allowed for R integers, the result will be a numeric vector in R +- If the value of an Arrow uint32 falls outside the range allowed for R integers, the result will be a numeric vector in R - If the value of an Arrow int64 variable falls outside the range allowed for R integers, the result will be a `bit64::integer64` vector in R - If the user sets `options(arrow.int64_downcast = FALSE)`, the Arrow int64 type always yields a `bit64::integer64` vector in R regardless of the value + - Arrow uint64 types are always converted to numeric (double) vectors in R. + Note that doubles cannot exactly represent all uint64 values; precision may + be lost for values above 2^53. Review Comment: The new `uint64` bullet is indented as if it were a nested list item under the previous bullet, and the continuation lines are inconsistently indented. This will render oddly in the vignette (the `uint64` note may appear as a sub-bullet of the `arrow.int64_downcast` item). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
