westonpace commented on a change in pull request #10205:
URL: https://github.com/apache/arrow/pull/10205#discussion_r631921805
##########
File path: cpp/src/arrow/util/future.h
##########
@@ -78,28 +110,32 @@ struct ContinueFuture {
template <typename ContinueFunc, typename... Args,
typename ContinueResult = result_of_t<ContinueFunc && (Args &&
...)>,
typename NextFuture = ForReturn<ContinueResult>>
- typename std::enable_if<!std::is_void<ContinueResult>::value &&
- !is_future<ContinueResult>::value>::type
+ typename std::enable_if<
+ !std::is_void<ContinueResult>::value &&
!is_future<ContinueResult>::value &&
+ (!NextFuture::is_empty || std::is_same<ContinueResult,
Status>::value)>::type
Review comment:
I added some comments helping to explain how each are different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
