Copilot commented on code in PR #50444:
URL: https://github.com/apache/arrow/pull/50444#discussion_r3551909575
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -4612,8 +4550,10 @@ def test_to_pandas_extension_dtypes_mapping():
def test_to_pandas_extension_dtypes_mapping_complex_type():
# https://github.com/apache/arrow/pull/44720
- if Version(pd.__version__) < Version("1.5.2"):
- pytest.skip("Test relies on pd.ArrowDtype")
+ # For the pandas issue, see backport commit to 2.0.2:
+ #
https://github.com/pandas-dev/pandas/commit/c8cd0277f8f889c5db7463ef7f36b495b5c9de69
+ if Version(pd.__version__) < Version("2.0.2"):
+ pytest.skip("ArrowDtype.type doesn't support struct before pandas
2.0.2")
Review Comment:
The PR sets the minimum supported pandas version to 2.0.0 (see pandas-shim +
docs + CI), but this test explicitly skips for pandas < 2.0.2 due to a pandas
bug. That implies at least some ArrowDtype(struct) functionality is not
actually supported on the declared minimum version. Please either (a) bump the
minimum supported pandas version to 2.0.2 everywhere (shim check, docs, CI
matrix) or (b) add/adjust a workaround so the behavior is supported on
2.0.0/2.0.1 (and keep the test running on the minimum version).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
