pitrou commented on code in PR #50444:
URL: https://github.com/apache/arrow/pull/50444#discussion_r3552013841
##########
.github/workflows/python.yml:
##########
@@ -79,11 +79,11 @@ jobs:
image: conda-python
title: AMD64 Conda Python 3.12 Without Pandas
python: "3.12"
- - name: conda-python-3.11-pandas-1.5.2
+ - name: conda-python-3.11-pandas-2.0.0
image: conda-python-pandas
- title: AMD64 Conda Python 3.11 Pandas 1.5.2
+ title: AMD64 Conda Python 3.11 Pandas 2.0.0
python: "3.11"
- pandas: "1.5.2"
+ pandas: "2.0.0"
Review Comment:
How about 2.0.3 which seems the latest in the 2.0.x line?
##########
dev/tasks/tasks.yml:
##########
@@ -727,7 +727,7 @@ tasks:
############################## Integration tests ############################
-{% for python_version, pandas_version, numpy_version, cache_leaf in [("3.11",
"1.5.2", "1.23.2", True),
+{% for python_version, pandas_version, numpy_version, cache_leaf in [("3.11",
"2.0.0", "1.23.2", True),
Review Comment:
Same comment re 2.0.3
##########
python/pyarrow/src/arrow/python/arrow_to_pandas.cc:
##########
@@ -1293,7 +1293,7 @@ struct ObjectWriterVisitor {
PyObject** out) {
ARROW_DCHECK(internal::BorrowPandasDataOffsetType() != nullptr);
// DateOffset objects do not add nanoseconds component to pd.Timestamp.
- // as of Pandas 1.3.3
+ // as of Pandas 1.3.3
// (https://github.com/pandas-dev/pandas/issues/43892).
Review Comment:
It looks like https://github.com/pandas-dev/pandas/issues/43892 was fixed in
1.4, can this piece of code be simplified? (though I have no idea how :))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
