metsw24-max commented on PR #49883: URL: https://github.com/apache/arrow/pull/49883#issuecomment-4928119579
@tadeja applied all three: `Reserve` is back to the one-line `Resize` call, restored the negative check in `TypedBufferBuilder<bool>::Resize` and added a `NegativeInputs` test for the bool builder so it stays covered, plus the `static_cast<int64_t>` in the overflow test. Also took the optional suggestion, so all the new error messages now include the offending values like `ValidateBufferCapacity`. Buffer tests pass locally. On the conbench report, the flagged benchmarks (bpacking, tensor conversion) don't appear to go through the changed BufferBuilder paths, so I'd guess most of that is noise, though happy to dig into specific ones if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
