Mandukhai-Alimaa commented on code in PR #4488:
URL: https://github.com/apache/arrow-adbc/pull/4488#discussion_r3553810710
##########
go/adbc/sqldriver/flightsql/README.md:
##########
@@ -49,7 +49,7 @@ import (
)
func main() {
- db, err := sql.Open("flightsql", "uri=grpc://localhost:12345")
+ db, err := sql.Open("flightsql",
"uri=flightsql://localhost:12345?transport=tcp")
Review Comment:
This is a proposal on what the URI might look like. I will make another
commit for the implementation soon, then we can merge both in.
##########
go/adbc/sqldriver/flightsql/README.md:
##########
@@ -49,7 +49,7 @@ import (
)
func main() {
- db, err := sql.Open("flightsql", "uri=grpc://localhost:12345")
+ db, err := sql.Open("flightsql",
"uri=flightsql://localhost:12345?transport=tcp")
Review Comment:
This is a proposal on what the URI might look like. I will make another
commit for the implementation soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
