Mandukhai-Alimaa commented on code in PR #4488:
URL: https://github.com/apache/arrow-adbc/pull/4488#discussion_r3560428846


##########
docs/source/driver/flight_sql.rst:
##########
@@ -81,6 +81,45 @@ the :c:struct:`AdbcDatabase`.
 
       .. recipe:: ../../../go/adbc/driver/flightsql/example_usage_test.go
 
+URI Format
+----------
+
+The "uri" option accepts URIs using the ``flightsql://`` scheme.  The
+transport is selected with the ``transport`` query parameter, which is
+matched case-insensitively:
+
+``flightsql://<host>:<port>``
+    Connect over gRPC with TLS (secure).  This is the default when no
+    ``transport`` query parameter is given.
+
+``flightsql://<host>:<port>?transport=tls``

Review Comment:
   Flight SQL JDBC doesn’t seem to define this for domain sockets. 
`useEncryption=true|false` only switches between the TCP/TLS cases. 



##########
docs/source/driver/flight_sql.rst:
##########
@@ -81,6 +81,45 @@ the :c:struct:`AdbcDatabase`.
 
       .. recipe:: ../../../go/adbc/driver/flightsql/example_usage_test.go
 
+URI Format
+----------
+
+The "uri" option accepts URIs using the ``flightsql://`` scheme.  The
+transport is selected with the ``transport`` query parameter, which is
+matched case-insensitively:
+
+``flightsql://<host>:<port>``
+    Connect over gRPC with TLS (secure).  This is the default when no
+    ``transport`` query parameter is given.
+
+``flightsql://<host>:<port>?transport=tls``

Review Comment:
   Flight SQL JDBC doesn’t seem to define this for domain 
sockets.`useEncryption=true|false` only switches between the TCP/TLS cases. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to