fornwall opened a new pull request, #4496: URL: https://github.com/apache/arrow-adbc/pull/4496
`TestSqlQueryFloats` and `TestSqlSchemaFloats` hardcoded SELECT CAST(1.5 AS FLOAT), whose `FLOAT` type name is not valid in every SQL dialect (GoogleSQL in BigQuery accepts only `FLOAT64` - Spanner also `FLOAT32`). Add a generic `DriverQuirks::RewriteSql(query_id, default_sql)` hook. It is keyed by a stable query id of the form `<test>::<description>` (e.g. `StatementTest::TestSqlQueryFloats::cast-1.5-as-float`) so driver overrides switch on the id, and takes the default query as an argument so the base method just returns it. Drivers whose dialect differs can override the whole query. Wire it into the two float-cast select tests to start with to fix the `FLOAT` issue - it can be inserted into other tests on demand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
