fornwall commented on code in PR #4496:
URL: https://github.com/apache/arrow-adbc/pull/4496#discussion_r3557329851
##########
c/validation/adbc_validation.h:
##########
@@ -156,6 +156,17 @@ class DriverQuirks {
/// \brief Return the SQL to reference the bind parameter of the given index
virtual std::string BindParameter(int index) const { return "?"; }
+ /// \brief Rewrite a SQL query used by a validation test, identified by a
+ /// stable query id.
+ ///
+ /// The default implementation returns \p default_sql unchanged. Drivers
+ /// whose SQL dialect differs can override this and switch on \p query_id
+ /// to substitute an equivalent query.
+ virtual std::string RewriteSql(std::string_view query_id,
+ std::string_view default_sql) const {
+ return std::string(default_sql);
+ }
Review Comment:
Did that in 25a7fd2ae6d2263374a7153f395559c1c61eac60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
