raulcd commented on code in PR #48223:
URL: https://github.com/apache/arrow/pull/48223#discussion_r3556984793
##########
ci/scripts/cpp_build.sh:
##########
@@ -145,164 +152,166 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
fi
fi
meson setup \
- --prefix=${MESON_PREFIX:-${ARROW_HOME}} \
- --buildtype=${ARROW_BUILD_TYPE:-debug} \
+ --prefix="${MESON_PREFIX:-${ARROW_HOME}}" \
+ --buildtype="${ARROW_BUILD_TYPE:-debug}" \
--pkg-config-path="${CONDA_PREFIX}/lib/pkgconfig/" \
-Dauto_features=enabled \
-Dfuzzing=disabled \
-Ds3=disabled \
. \
- ${source_dir}
+ "${source_dir}"
CC="${ORIGINAL_CC}"
CXX="${ORIGINAL_CXX}"
elif [ "${ARROW_EMSCRIPTEN:-OFF}" = "ON" ]; then
n_jobs=2 # Emscripten build fails on docker unless this is set really low
+ # shellcheck source=/dev/null
Review Comment:
just for me to understand, what does this do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
