hiroyuki-sato commented on code in PR #48223:
URL: https://github.com/apache/arrow/pull/48223#discussion_r3558018542
##########
ci/scripts/cpp_build.sh:
##########
@@ -145,164 +152,166 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
fi
fi
meson setup \
- --prefix=${MESON_PREFIX:-${ARROW_HOME}} \
- --buildtype=${ARROW_BUILD_TYPE:-debug} \
+ --prefix="${MESON_PREFIX:-${ARROW_HOME}}" \
+ --buildtype="${ARROW_BUILD_TYPE:-debug}" \
--pkg-config-path="${CONDA_PREFIX}/lib/pkgconfig/" \
-Dauto_features=enabled \
-Dfuzzing=disabled \
-Ds3=disabled \
. \
- ${source_dir}
+ "${source_dir}"
CC="${ORIGINAL_CC}"
CXX="${ORIGINAL_CXX}"
elif [ "${ARROW_EMSCRIPTEN:-OFF}" = "ON" ]; then
n_jobs=2 # Emscripten build fails on docker unless this is set really low
+ # shellcheck source=/dev/null
Review Comment:
@raulcd
https://github.com/apache/arrow/pull/48223/changes#diff-33aff62d004f99c7ba50c3f5956b6e6124976ae3ac9c6bfbe2d91640527e9a8eL110
In the example below, `enable_offline_build.sh` does not exist in the same
directory as `cpp_build.sh`.
```bash
# shellcheck source=/dev/null
. enable_offline_build.sh
```
ShellCheck checks whether the sourced file exists. As a result, it reports
SC1091.
Adding `# shellcheck source=/dev/null` suppresses this check.
For more information, see: https://www.shellcheck.net/wiki/SC1091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
