westonpace commented on pull request #10205: URL: https://github.com/apache/arrow/pull/10205#issuecomment-840876262
Ok, @bkietz 's tricks **almost** worked. Turns out some older MSVC compilers can get confused when figuring out overloads based only on the return value (https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/39152166/job/ewlnjonukpbaiaet)... ``` ..\src\arrow/util/future.h(603): note: could be 'std::enable_if<false,ForReturnImpl<Return>::type>::type arrow::Future<std::shared_ptr<arrow::RecordBatch>>::Then<_Ty,arrow::Future<std::shared_ptr<arrow::RecordBatch>>::Then::<lambda_0aa43ac6ba74e671a09c4f431b6e6fbf>,ForReturnImp ``` ^-- MSVC is considering the overload even though the return type is `std::enable_if<false,ForReturnImpl<Return>::type>::type` So I went ahead and just made a dummy method arg which appears to have satisfied Windows (MinGW failures are unrelated I believe). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
