dmitry-chirkov-dremio commented on code in PR #50372:
URL: https://github.com/apache/arrow/pull/50372#discussion_r3581607264


##########
cpp/src/gandiva/filter.cc:
##########
@@ -45,10 +46,13 @@ Status Filter::Make(SchemaPtr schema, ConditionPtr 
condition,
   ARROW_RETURN_IF(configuration == nullptr,
                   Status::Invalid("Configuration cannot be null"));
 
+  auto folded_condition =

Review Comment:
   Could we add a `Filter` test for this path too? The new tests here are 
projector-only, but filter now also depends on the folded tree for both build 
behavior and cache-keying.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to