dmitry-chirkov-dremio commented on code in PR #50372:
URL: https://github.com/apache/arrow/pull/50372#discussion_r3593400881
##########
cpp/src/gandiva/projector.cc:
##########
@@ -283,6 +288,10 @@ Status Projector::ValidateArrayDataCapacity(const
arrow::ArrayData& array_data,
const std::string& Projector::DumpIR() { return llvm_generator_->ir(); }
+const std::string& Projector::DumpUnoptimizedIR() {
Review Comment:
The cache-hit case is fixed, but this guard still consults the live mutable
`Configuration`. If a projector is built with `dump_ir=false` and the shared
configuration is subsequently changed with `set_dump_ir(true)`, this check
passes even though `FinalizeModule()` never captured the unoptimized IR, so
`Engine::unoptimized_ir()` still reaches its DCHECK. Could availability be
recorded at build time, or exposed by `Engine` based on the stored IR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
