dmitry-chirkov-dremio commented on code in PR #48597:
URL: https://github.com/apache/arrow/pull/48597#discussion_r3581621939


##########
cpp/src/gandiva/node.h:
##########
@@ -117,6 +121,10 @@ class GANDIVA_EXPORT FieldNode : public Node {
     return "(" + field()->type()->ToString() + ") " + field()->name();
   }
 
+  std::string ToCacheKeyString() const override {
+    return "(" + field()->type()->ToString() + ") ";

Review Comment:
   Perhaps add [failing] tests first to validate this theory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to