dmitry-chirkov-dremio commented on code in PR #48597:
URL: https://github.com/apache/arrow/pull/48597#discussion_r3581625618
##########
cpp/src/gandiva/expr_validator.cc:
##########
@@ -72,20 +72,6 @@ Status ExprValidator::Visit(const FieldNode& node) {
Status::ExpressionValidationError("Field ",
node.field()->name(),
" has unsupported data
type ",
node.return_type()->name()));
-
Review Comment:
This removes the only build-time check that every referenced field exists in
the schema and matches the expression's field definition. I don't think the new
runtime type check fully replaces that guarantee.
With this gone, `Projector::Make` / `Filter::Make` can succeed for
expressions that reference missing fields, and the later
`CheckEvalBatchFieldType()` path only validates columns that are actually
present in the incoming batch. That means a missing referenced field can slip
through without a clean validation error.
Was this intentonal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
