Rich-T-kid commented on code in PR #10317:
URL: https://github.com/apache/arrow-rs/pull/10317#discussion_r3587478608
##########
arrow-buffer/src/buffer/mutable.rs:
##########
@@ -140,13 +174,13 @@ impl MutableBuffer {
NonNull::new(raw_ptr).unwrap_or_else(||
handle_alloc_error(layout))
Review Comment:
nice, I also have interest in
https://github.com/apache/datafusion/issues/22758 &
https://github.com/apache/arrow-rs/issues/8938
> If we have a global allocator that internally limits how many allocations
it dishes out, we can course correct in code if an error is returned
make sense.
Would the next step be to replace all OOM panics with error propagation? Off
the top of my head, I think arrow-buffer's crate deals with memory management
most directly out of all the crates, so it would be a good place to start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
