Jefffrey commented on PR #10317: URL: https://github.com/apache/arrow-rs/pull/10317#issuecomment-4993513688
> from the docs for [handle_alloc_error](https://doc.rust-lang.org/beta/std/alloc/fn.handle_alloc_error.html) > > > it may either panic (resulting in unwinding or aborting as per configuration for all panics), or abort the process (with no unwinding). > > it seems that once this branch is hit there isn't much for the process to do anyway? in both cases it aborts the process. yeah I was mainly looking at this part of its doc: > Callers of memory allocation APIs wishing to cease execution in response to an allocation error are encouraged to call this function, rather than directly invoking [panic!](https://doc.rust-lang.org/beta/core/macro.panic.html) or similar. but its probably fine i guess? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
