loctormor commented on code in PR #50526: URL: https://github.com/apache/arrow/pull/50526#discussion_r3604987651
########## cpp/cmake_modules/SetupCxxFlags.cmake: ########## @@ -49,7 +49,7 @@ endif() if(ARROW_CPU_FLAG STREQUAL "x86") # x86/amd64 compiler flags, msvc/gcc/clang if(MSVC) - set(ARROW_SSE4_2_FLAG "/arch:SSE4.2") + set(ARROW_SSE4_2_FLAG "") Review Comment: SSE4.2 appears to behave identically for x64. The official Microsoft documentation lists SSE4.2 as valid flag for msvc-180, but the compiler begs to disagree. I am having trouble finding documentation to support this, but building with x64 does produce the same nuisance warnings as with x86. This appears to be because SSE2 and its extensions are implicitly targeted as the baseline. Here is the relevant usage line on my machine: Command> "C:\Program Files\Microsoft Visual Studio\18\Professional\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\cl.exe" /? 2>nul | findstr "arch:" [Output] /arch:<AVX|AVX2|AVX512> minimum CPU architecture requirements, one of: Next week I will expand the scope of testing to see if there is *any* MSVC version that supports the SSE4.2 flag without warnings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
