loctormor commented on code in PR #50526:
URL: https://github.com/apache/arrow/pull/50526#discussion_r3639059236
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -49,7 +49,7 @@ endif()
if(ARROW_CPU_FLAG STREQUAL "x86")
# x86/amd64 compiler flags, msvc/gcc/clang
if(MSVC)
- set(ARROW_SSE4_2_FLAG "/arch:SSE4.2")
+ set(ARROW_SSE4_2_FLAG "")
Review Comment:
Update: The flag is invalid for all "cl.exe" executables that ship with
Visual Studio 2022 (VC17) and Visual Studio 2026 (VC18).
Valid flags for x86:
/arch:<IA32|SSE|SSE2|AVX|AVX2|AVX512>
Valid flags for x64:
/arch:<AVX|AVX2|AVX512>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
