hhhizzz commented on code in PR #10288:
URL: https://github.com/apache/arrow-rs/pull/10288#discussion_r3610656284
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -1403,7 +1408,7 @@ impl ParquetRecordBatchReader {
if mask_chunk.chunk_rows == 0 {
if mask_cursor.is_empty() && mask_chunk.selected_rows
== 0 {
- return Ok(None);
+ break;
Review Comment:
This branch was unreachable for the same reason. After leading skips are
consumed, the cursor is positioned at a selected row, and the loaded range
containing that row has a non-empty extent. Therefore a valid reader call
always produces a non-zero `chunk_rows`.
I removed this branch and added an async regression test where the final
selected row is followed by fully skipped pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
