hhhizzz commented on code in PR #10288:
URL: https://github.com/apache/arrow-rs/pull/10288#discussion_r3610664707
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -1381,13 +1382,17 @@ impl ParquetRecordBatchReader {
if batch_size == 0 {
return Ok(None);
}
- match self.read_plan.row_selection_cursor_mut() {
+ let filter_mask = match self.read_plan.row_selection_cursor_mut() {
Review Comment:
I extracted the Mask path into `read_mask_batch` and moved mask assembly
into `FilterMaskAccumulator`.
The accumulator explicitly models `Empty -> Single -> Combined`: the first
`BooleanBuffer` remains zero-copy, the second chunk promotes it to a builder,
and subsequent chunks are appended. `next_inner` now only dispatches the
selection strategy, while the helper owns the skip, decode, accumulate,
consume, and filter workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
