mkzung commented on PR #50475: URL: https://github.com/apache/arrow/pull/50475#issuecomment-5029457220
Friendly ping on this one. The workflow runs look like they're still waiting on approval, so none of the C++ or Python jobs have actually executed here yet. @jorisvandenbossche you diagnosed this back in 2023 and suggested letting it pick AdaptiveIntBuilder vs AdaptiveUIntBuilder depending on the signedness of the original index type, so you may want to see why I didn't go that way. It changes which class MakeDictionaryBuilder returns, and util/converter.h, json/from_string.cc and the R binding all cast that result to DictionaryBuilder<T>. TestDictionaryUnifier.ChunkedArrayNestedDict trips a checked_pointer_cast DCHECK straight away. This keeps one builder class instead and preserves the requested signedness where the index type is reported. Happy to rebase if it's gone stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
