mkzung commented on PR #50475:
URL: https://github.com/apache/arrow/pull/50475#issuecomment-5106270549
Thanks, done:
- `MaybeUnsignedIndexType`: the default case is unreachable (the adaptive
builder only produces
signed int8/16/32/64), so it's `arrow::Unreachable` now.
- Both tests now build the array and check the finished array's index type,
not just the
builder's.
- Renamed to `WidthAdaptsWhenUnsigned`.
The uint8-widens-at-128 bit is still a documented limitation; happy to do
the unsigned-range
follow-up separately if you want it. The red R/Windows checks look like
infra, not this change
(bioconductor was down for R, MinGW timed out in the deps).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
