hhhizzz commented on PR #10141: URL: https://github.com/apache/arrow-rs/pull/10141#issuecomment-5035510795
Thanks for the updates. I re-ran the `row_selection_cursor` benchmark on the latest head with three alternating rounds against the main baseline containing #10288. The new early-exit run-count logic substantially reduces mask-backed Auto overhead (for example, L4 drops from +24.5% to +2.8%), and the measured crossover remains between L28 and L32, so the current threshold of 32 still looks appropriate. The residual selector variation is codegen/layout-sensitive rather than additional cursor work. The sparse-page integration and added coverage also look good. LGTM from both correctness and performance perspectives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
