haohuaijin commented on PR #10141: URL: https://github.com/apache/arrow-rs/pull/10141#issuecomment-5066534191
Thanks for your review @alamb i filed follow-up issues to track some performance improve - #10422 — reuse the lazy selector cache in `into_selectors_vec` (review finding 4) - #10423 — avoid eager mask→RLE expansion in mixed `intersection`/`union` (review finding 6) - #10424 — split up `selection/mod.rs` - #10425 — in-place bitwise ops for `intersect_masks`/`union_masks` The `RowSelectionIter` slice-iterator specializations (review finding 5) are addressed in this PR directly in [86610b5](https://github.com/apache/arrow-rs/pull/10141/commits/86610b5bbb3a2a91c7cae070eddbb57fff24e015) and [bdf2726](https://github.com/apache/arrow-rs/pull/10141/commits/bdf2726c21930d5264b49c751c9b5c8f0fc569c4) cc @hhhizzz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
