Reranko05 commented on code in PR #50568:
URL: https://github.com/apache/arrow/pull/50568#discussion_r3635300887
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -310,10 +311,26 @@ macro(resolve_dependency DEPENDENCY_NAME)
elseif(${DEPENDENCY_NAME}_SOURCE STREQUAL "BUNDLED")
build_dependency(${DEPENDENCY_NAME})
elseif(${DEPENDENCY_NAME}_SOURCE STREQUAL "SYSTEM")
- find_package(${FIND_PACKAGE_ARGUMENTS} REQUIRED)
- if(ARG_FORCE_ANY_NEWER_VERSION AND ARG_REQUIRED_VERSION)
+ if(ARG_FALLBACK_TO_BUNDLED_ON_OLD_SYSTEM_VERSION)
Review Comment:
My intention with the additional logic was to handle the case where the
system package is found but its version is older than the required simdjson
v4.0.0. But we can use `-Dsimdjson_SOURCE=BUNDLED` explicitly for the jobs that
use `-DARROW_DEPENDENCY_SOURCE=SYSTEM`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
