Reranko05 commented on PR #50568:
URL: https://github.com/apache/arrow/pull/50568#issuecomment-5055606650

   @kou I reran the benchmark in a Release build using the same temporary 
benchmark (`IntegrationJsonWriter::WriteRecordBatch() + Finish()` on a 1M-row 
`RecordBatch`).
   
   Results:
   - main (RapidJSON): 324 ms
   - This PR (simdjson): 490 ms
   - This PR with a naive `std::ostringstream` implementation: 1323 ms
   
   So, in this benchmark, the `std::ostringstream` implementation is about 2.7× 
slower than the current implementation and about 4× slower than the RapidJSON 
implementation. My absolute timings are still higher than the ~65–69 ms you 
reported, so I suspect my benchmark setup differs from yours.
   
   <img width="400" height="250" alt="download" 
src="https://github.com/user-attachments/assets/9fe5b890-26b4-4464-b7d6-a9a76bd092f4";
 />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to