Reranko05 opened a new pull request, #50633:
URL: https://github.com/apache/arrow/pull/50633

   ### Rationale for this change
   
   The workaround introduced for the macOS 11.3 SDK currently uses a global 
`add_compile_definitions(SIMDJSON_CONCEPT_DISABLED=1)`.
   
   Since this workaround is only needed when building the bundled simdjson 
dependency, scope it to the `simdjson` target inside `build_simdjson()` instead 
of applying it globally.
   
   ### What changes are included in this PR?
   
   - Move the macOS SDK 11.3 workaround into `build_simdjson()`.
   - Replace the global `add_compile_definitions()` with 
`target_compile_definitions(simdjson PRIVATE SIMDJSON_CONCEPT_DISABLED=1)`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to