Reranko05 commented on code in PR #50633: URL: https://github.com/apache/arrow/pull/50633#discussion_r3649960482
########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -2832,6 +2823,13 @@ function(build_simdjson) fetchcontent_makeavailable(simdjson) + # The macOS 11.3 SDK has incomplete C++20 concepts support, which prevents + # simdjson headers from compiling. Disable simdjson concepts for this SDK. + if(CMAKE_OSX_SYSROOT AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$") + message(STATUS "Disabling simdjson concepts for macOS SDK 11.3") + target_compile_definitions(simdjson PRIVATE SIMDJSON_CONCEPT_DISABLED=1) Review Comment: Done. Changed it to `PUBLIC`, can you please re-run the Crossbow Job. ########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -2832,6 +2823,13 @@ function(build_simdjson) fetchcontent_makeavailable(simdjson) + # The macOS 11.3 SDK has incomplete C++20 concepts support, which prevents + # simdjson headers from compiling. Disable simdjson concepts for this SDK. + if(CMAKE_OSX_SYSROOT AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$") + message(STATUS "Disabling simdjson concepts for macOS SDK 11.3") + target_compile_definitions(simdjson PRIVATE SIMDJSON_CONCEPT_DISABLED=1) Review Comment: @kou Done. Changed it to `PUBLIC`, can you please re-run the Crossbow Job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
