maltzsama commented on issue #96: URL: https://github.com/apache/arrow-swift/issues/96#issuecomment-5080146264
This relates to the proposal in [#10](https://github.com/apache/arrow-swift/issues/10#issuecomment-5078784516) — replacing the Go generator with `arrow-testing`. I have a draft PR open that implements the first part: [#185](https://github.com/apache/arrow-swift/pull/185). It adds the submodule and conformance tests for file/stream readers. Before I go further, I'd like feedback on the overall direction: 1. **Access footer blocks** – Should we add an API to `ArrowReader` to expose footer metadata, so tests can verify block alignment directly? Or is that overkill if we rely on gold files? 2. **Gold files** – The plan is to use the existing `arrow-ipc-stream/integration/cpp-21.0.0/generated_binary.arrow_file` and `.stream` files from `arrow-testing` to validate that: - Our reader can parse files produced by other implementations - Files written by `ArrowWriter` match the expected format (compare with gold files or use Archery) 3. **Archery integration** – Is wiring Archery into CI the preferred long-term solution, or should we keep it simpler and just run the gold files directly in Swift tests? After #185 merges, the immediate next step would be reading the binary gold files and adding assertions that cover the Block padding fix from #95. I'd appreciate any guidance on which of these approaches makes sense before I continue. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
